-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: simulation input from GenParticleCollection #29046
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29046/13913
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: IOMC/EventVertexGenerators @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Have the tests actually been triggered? I can't see any results... |
please test |
The tests are being triggered in jenkins. |
Thanks @civanch ! |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
As mentioned here: #29037 (comment), it could be helpful to get this PR merged as fast as reasonable to address the conflicts in the other PR. Thanks in advance! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PPS: simulation input from GenParticleCollection (backport of #29046 to 10_6_X)
PR description:
This PR adds a possibility to run fast ("direct") forward-proton simulation starting with GenParticleCollection, for details see https://twiki.cern.ch/twiki/bin/view/CMS/TaggedProtonsDirectSimulation.
No changes are expected in the results of the standard workflows.
PR validation:
Since the updated module is not present in the standard sequences, tests with runTheMatrix were not performed.
Instead, the new functionality was tested with this config file:
https://github.com/CTPPS/cmssw/tree/pps_zx_mc_10_6/test-simu-GenParticle