PPS: simulation input from GenParticleCollection

[jan-kaspar]

PR description:

This PR adds a possibility to run fast ("direct") forward-proton simulation starting with GenParticleCollection, for details see https://twiki.cern.ch/twiki/bin/view/CMS/TaggedProtonsDirectSimulation.

No changes are expected in the results of the standard workflows.

PR validation:

Since the updated module is not present in the standard sequences, tests with runTheMatrix were not performed.

Instead, the new functionality was tested with this config file:
https://github.com/CTPPS/cmssw/tree/pps_zx_mc_10_6/test-simu-GenParticle

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29046/13913

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File IOMC/EventVertexGenerators/src/BeamDivergenceVtxGenerator.cc modified in PR(s): PPS: rename directories with misleading names #29037

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[jan-kaspar]

please test

Have the tests actually been triggered? I can't see any results...

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4911/console Started: 2020/02/27 11:25

[jan-kaspar]

Thanks @civanch !

[cmsbuild]

+1
Tested at: 435e55c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6d98f/4911/summary.html
CMSSW: CMSSW_11_1_X_2020-02-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6d98f/4911/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a6d98f/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2679706
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2679385
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jan-kaspar]

As mentioned here: #29037 (comment), it could be helpful to get this PR merged as fast as reasonable to address the conflicts in the other PR. Thanks in advance!

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1