Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shared HandleExceptionFactory to be const #29089

Merged
merged 1 commit into from Mar 6, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

All Handle types now use the potentially shared HandleExceptionFactory as a const.
This was pointed out by the static analyzer.

PR validation:

All framework packages compile.

All Handle types now use the potentially shared HandleExceptionFactory as a const.
This was pointed out by the static analyzer.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29089/13982

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Common
FWCore/Framework
FWCore/TestProcessor

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4982/console Started: 2020/03/03 22:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2020

+1
Tested at: 82d7a52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a3c3e/4982/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a3c3e/4982/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a3c3e/4982/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a3c3e/4982/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680373
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680015
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@makortel
Copy link
Contributor

makortel commented Mar 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 13baa9d into cms-sw:master Mar 6, 2020
@Dr15Jones Dr15Jones deleted the constExceptionFactory branch March 11, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants