Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to configure APVCyclePhaseProducerFromL1TS with a DB object #2910

Merged
merged 3 commits into from Mar 25, 2014

Conversation

venturia
Copy link
Contributor

This pull request requires a new tag in the Global Tag to work properly. ALCA managers are informed. The tag will be needed for sure when the clients of the EDProducer APVCyclePhaseProducerFromL1TS will switch to the new configuration which uses the DB input to configure it.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @venturia for CMSSW_7_1_X.

Added the possibility to configure APVCyclePhaseProducerFromL1TS with a DB object

It involves the following packages:

CalibTracker/SiStripESProducers
CondFormats/SiStripObjects
DPGAnalysis/SiStripTools

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @diguida, @rcastello, @ggovi, @vadler, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Mar 19, 2014

+1

@apfeiffer1
Copy link
Contributor

+1

@diguida
Copy link
Contributor

diguida commented Mar 22, 2014

-1
@ktf I am preparing a PR with the GTs in autoCond needed for this one to work. ETA: 1 day

@ktf
Copy link
Contributor

ktf commented Mar 24, 2014

Yeah, I noticed this was not a good idea only after having sent the message. Still waiting for the merge.

@diguida
Copy link
Contributor

diguida commented Mar 24, 2014

@ktf @venturia
#2992 contains the new GTs. Once in, I can accept this one.

@diguida
Copy link
Contributor

diguida commented Mar 25, 2014

+1
The new GTs are in

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 25, 2014
Tracking -- Added the possibility to configure APVCyclePhaseProducerFromL1TS with a DB object
@ktf ktf merged commit 290e2d4 into cms-sw:CMSSW_7_1_X Mar 25, 2014
@venturia venturia deleted the apvcyle_fromDB-71x branch March 31, 2014 20:23
davidlange6 added a commit that referenced this pull request Apr 3, 2014
shervin86 pushed a commit to shervin86/cmssw that referenced this pull request May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants