Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernized L1TCaloRCTToUpgradeConverter #29118

Merged
merged 1 commit into from Mar 16, 2020
Merged

Modernized L1TCaloRCTToUpgradeConverter #29118

merged 1 commit into from Mar 16, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Made into a global module
  • Used EDPutToken
  • Filled in fillDescriptions
  • Changed to modern C++ constructs
  • Consolidated into one file

PR validation:

Code compiles

@Dr15Jones
Modernized L1TCaloRCTToUpgradeConverter
38a58d2 
-Made into a global module
-Used EDPutToken
-Filled in fillDescriptions
-Changed to modern C++ constructs
-Consolidated into one file
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Mar 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

prompted by #25090

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29118/14024

  • This PR adds an extra 12KB to repository

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5016/console Started: 2020/03/05 20:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

+1
Tested at: 38a58d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c6cfc/5016/summary.html
CMSSW: CMSSW_11_1_X_2020-03-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c6cfc/5016/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680220
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Dr15Jones
Copy link
Contributor Author

ping

@silviodonato
Copy link
Contributor

This is a technical PR. @benkrikler @rekovic Do you have any objections?

@silviodonato
Copy link
Contributor

merge
In case you have any comments, please let me know

@cmsbuild cmsbuild merged commit 2b2bc44 into cms-sw:master Mar 16, 2020
@cmsbuild cmsbuild mentioned this pull request Mar 17, 2020
Merged
@Dr15Jones Dr15Jones deleted the globalL1TCaloRCTToUpgradeConverter branch March 17, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @silviodonato