Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sim] Reduce a TruncTubs cutaway box to a reasonable size #29131

Merged
merged 1 commit into from Mar 7, 2020

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Mar 6, 2020

PR description:

TruncTubs is a CMS-specific shape widely used in both CMS MagneticField geometry and CMS detector descriptions. It's defined as follows:

41044065-a0689338-69a5-11e8-879c-90a69f9d9634
41044066-a0a6e48a-69a5-11e8-9c51-b5ef932542e5
41044067-a0d71ed4-69a5-11e8-8437-67e72babc581

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29131/14043

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Mar 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5035/console Started: 2020/03/06 15:39

@etcherniaev
Copy link

The dimensions of the cutaway box may depend on how the box is centred. I've noticed in the GDML file that in case of YE1_br the box was shifted along X axis.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+1
Tested at: 3caf242
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45e4ca/5035/summary.html
CMSSW: CMSSW_11_1_X_2020-03-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45e4ca/5035/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680219
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Mar 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3107a10 into cms-sw:master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants