SimTrack to CSC digi and stub matching in CSC Validation code #29139
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29139/14065
|
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: Validation/MuonCSCDigis @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@dildick You are not enabling the code in any py config file, so no plots are produced, is this intentional? Thanks |
|
@jfernan2 Yes, for now I'm not adding plots to the validation package yet. |
|
In a next PR, I want to add efficiency plots for wire digi, comparator digi, ALCT, CLCT and LCT. Not all plots necessarily have to be made for each validation. Some - perhaps even most - should be made for expert studies for the CSC local trigger emulator. |
|
+1 |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
please test workflow 23234.1001, 23434.1001 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
PR description:
This PR builds on top of #26249 and #29042. This code matches CSC wire/strip/comparator digis and ALCT/CLCT/LCT stubs to SimTracks.
Tao Huang and I have been developing this validation code since ~2013 and have been using it in our trigger studies for the GEM TDR, Muon Phase-II TP, Muon Upgrade TDR. Most recently in the L1T TDR (https://cms-docdb.cern.ch/cgi-bin/DocDB/RetrieveFile?docid=13929&filename=TDR-20-001-paper-v1.pdf&version=4, section 2.5.5).
PR validation:
The code was tested with WF 22034.0.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
FYI @tahuang1991