Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SONIC core in CMSSW #29141

Merged
merged 8 commits into from Mar 13, 2020
Merged

Introduce SONIC core in CMSSW #29141

merged 8 commits into from Mar 13, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Mar 6, 2020

PR description:

This PR introduces the core classes for SONIC as a new package in the HeterogeneousCore subsystem. This code is ported from https://github.com/hls-fpga-machine-learning/SonicCMS. Unit tests are included (based on the Acquire tests for ExternalWork in FWCore/Integration/test).

Documentation is provided in the package README, as well as in a presentation at the core software meeting.

This package will be supplemented by additional packages implementing concrete clients for different communication protocols as the needed externals become available. (A separate package for each communication protocol is foreseen in order to compartmentalize the different external dependencies.)

PR validation:

Unit tests run successfully.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29141/14067

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The code-checks are being triggered in jenkins.

@makortel
Copy link
Contributor

makortel commented Mar 6, 2020

assign heterogeneous

(until the new packages get added to categories_map.py, and I'd like to first agree on the naming)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29141/14068

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

New categories assigned: heterogeneous

@makortel,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

HeterogeneousCore/SonicCore

The following packages do not have a category, yet:

HeterogeneousCore/SonicCore
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Mar 6, 2020

please test

@makortel
Copy link
Contributor

makortel commented Mar 6, 2020

(as I mentioned in person) I'm not super happy with the name "Sonic" because it is not very descriptive, but I don't have any better concise suggestions either, so to me it is good enough.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5050/console Started: 2020/03/06 23:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: c67d250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce05aa/5160/summary.html
CMSSW: CMSSW_11_1_PY3_X_2020-03-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce05aa/5160/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2184 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2682093
  • DQMHistoTests: Total failures: 690
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2681403
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

please test for cc8_aarch64_gcc8

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: c67d250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce05aa/5167/summary.html
CMSSW: CMSSW_11_1_X_2020-03-12-2300
SCRAM_ARCH: cc8_aarch64_gcc8

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 270055f into cms-sw:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants