avoiding overflow in TDC regime

[pfs]

PR description:

• Issue: for very high energetic hits (equal or larger than the TDC saturation value), the value assigned to the digis was overflowing with respect to the mask and the hits ended up being assigned with a 0 energy.

• Changes expected: migration of hits with 0 ADC energy in TDC mode to 4096 ADC energy. This is very rare and requires very energetic photons/jets (typically >500 GeV)

• Impacts other PRs: no to my knowledge

PR validation:

Local production of approx. 2k events of photon gun events with E=500 GeV, uniform in pseudo-rapidity

DIGIs in TDC mode before the fix (sample 1):

DIGIs in TDC mode after the fix (sample 2):

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29186/14158

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29186/14158/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29186/14158/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29186/14159

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @pfs (Pedro Silva) for master.

It involves the following packages:

SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @lgray, @cseez, @apsallid, @deguio, @hatakeyamak this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5141/console Started: 2020/03/11 19:58

[cmsbuild]

+1
Tested at: 22b9604
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ce86d/5141/summary.html
CMSSW: CMSSW_11_1_X_2020-03-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ce86d/5141/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680257
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1