Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TYPELOOKUP_DATA_REG(SeedingLayerSetsBuilder) #2919

Merged
merged 1 commit into from Mar 21, 2014

Conversation

makortel
Copy link
Contributor

Leftover from #2378, I forgot to remove the use of this macro when the SeedingLayersESProducer was removed.

@Dr15Jones This should remove SeedingLayerSetsBuilder from your list of thread-unsafe ES products (as it is not such anymore)

I forgot (or actually didn't know) to remove this when the
SeedingLayerSetsBuilderESProducer was removed.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

Remove TYPELOOKUP_DATA_REG(SeedingLayerSetsBuilder)

It involves the following packages:

RecoTracker/TkSeedingLayers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2014

... checking

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2014

+1

for #2919 2132b5e
tested in CMSSW_7_1_X_2014-03-18-0200 (sign325 , in combination of pull2905-2906-2919-2926)

no regressions as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 21, 2014
Reco fixes -- Remove TYPELOOKUP_DATA_REG(SeedingLayerSetsBuilder)
@ktf ktf merged commit d0485b1 into cms-sw:CMSSW_7_1_X Mar 21, 2014
@makortel makortel deleted the seedingLayersFix branch October 20, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants