New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim59 Define the reconstruction geometry of ECAL #29190
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29190/14161
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CaloEventSetup @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda What part of the ECAL Reco geometry migration does this PR cover? How much more work is needed to complete he ECAL Reco geometry migration? |
@cvuosalo Here it defines the connection between EventSetup and producers for ECAL geometry. Earlier we completed the producer for Ecal barrel and for Endcap and Preshower, one need to see if the producer is completed. Rajdeep is looking into this. |
please test workflow 23234.1001, 23434.1001 |
The tests are being triggered in jenkins.
|
Hi,
All the changes refer to dd4hep application. I wonder why the additional tests are required. Nothing is changed for DDD applications. Anyway extra tests are always good. Regards
Sunanda
…________________________________
From: cmsbuild [notifications@github.com]
Sent: 12 March 2020 18:27
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim59 Define the reconstruction geometry of ECAL (#29190)
The tests are being triggered in jenkins.
Test Parameters:
* MATRIX_EXTRAS = 23434.1001,23234.1001
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29190 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOQTLBEBLQJDTDRIQY3RHELQBANCNFSM4LF5PT5A>.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
PR description:
Defines EcalXXXGeometryEP for dd4hep application
PR validation:
Tested with runTheMatrix.py
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special