FastSim readiness for DD4Hep migration

[sbein]

This pull request makes the changes necessary for the DD4Hep migration

PR description

The needs were to remove references to

1. DDCompactView
   one header include in FastSimulation/ShowerDevelopment/interface/FastHFShowerLibrary.h
   one instance declaration in FastSimulation/ShowerDevelopment/src/FastHFShowerLibrary.cc

2. DDFilteredView
   one class declaration in ShowerDevelopment/interface/FastHFShowerLibrary.h

->this object is never actually used (as far as I can tell!) so it shouldn't make any difference

3. DetectorDescription/Core
   one class declaration in ShowerDevelopment/interface/FastHFShowerLibrary.h
   one instance in FastSimulation/ShowerDevelopment/src/FastHFShowerLibrary.cc

PR validation

runTheMatrix.py -e -l 135.1
performed smoothly as expected

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29197/14182

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @sbein (Sam Bein) for master.

It involves the following packages:

FastSimulation/EventProducer
FastSimulation/ShowerDevelopment

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5182/console Started: 2020/03/15 13:51

[cmsbuild]

+1
Tested at: e9e552f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2534cc/5182/summary.html
CMSSW: CMSSW_11_1_X_2020-03-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2534cc/5182/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680593
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680271
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1