Fixed a bug in EmulatedME0SegmentProducer.cc

[dnash86]

Fixed parentheses, was causing buggy behavior previously.

[cmsbuild]

A new Pull Request was created by @dnash86 for CMSSW_6_2_X_SLHC.

Fixed a bug in EmulatedME0SegmentProducer.cc

It involves the following packages:

FastSimulation/Muons

@cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lveldere]

+1

was it the parentheses or the abs -> fabs change that fixed things?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

[dnash86]

I changed abs -> fabs while tinkering, to be consistent with above fabs
usage.

It was the change in parentheses that was the actual fix.

On Tue, Mar 18, 2014 at 6:01 PM, lveldere notifications@github.com wrote:

+1

was it the parentheses or the abs -> fabs change that fixed things?

Reply to this email directly or view it on GitHubhttps://github.com//pull/2920#issuecomment-37994423
.

[mark-grimes]

Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

Realised I should probably test some FastSim tests before merging.

[mark-grimes]

merge