Fix Python3 problems with #28920

[silviodonato]

As discussed during the Core software meeting, we can trivially fix the failures in PY3 IB by forcing int(self._options.nConcurrentLumis).
The error affecting almost all workflows in CMSSW_11_1_PY3_X_2020-03-16-2300 was

  File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/python/Configuration/Applications/ConfigBuilder.py", line 2235, in prepare
    if self._options.nConcurrentLumis > 1:
TypeError: '>' not supported between instances of 'str' and 'int'```
This bug was related to https://github.com/cms-sw/cmssw/pull/28920.

[silviodonato]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29219/14237

• This PR adds an extra 36KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5229/console Started: 2020/03/17 19:56

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/Applications

@cmsbuild, @silviodonato, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c9498ec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77f869/5229/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[davidlange6]

It may be an error in python3 but it’s a bug also in python 2 Probably worth knowing the impact of that bug On 17 Mar 2020, at 19:44, Silvio Donato <notifications@github.com> wrote:  As discussed during the Core software meeting, we can trivially fix the failures in PY3 IB by forcing int(self._options.nConcurrentLumis). The error affecting almost all workflows in CMSSW_11_1_PY3_X_2020-03-16-2300 was File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in &lt;module&gt; run() File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run configBuilder.prepare() File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/python/Configuration/Applications/ConfigBuilder.py", line 2235, in prepare if self._options.nConcurrentLumis &gt; 1: TypeError: '&gt;' not supported between instances of 'str' and 'int'``` This bug was related to #28920.

…

________________________________ You can view, comment on, or merge this pull request online at: #29219 Commit Summary * fix py3 compatib File Changes * M Configuration/Applications/python/ConfigBuilder.py<https://github.com/cms-sw/cmssw/pull/29219/files#diff-05daab1ca94b26f7bab27d1187d95415> (2) Patch Links: * https://github.com/cms-sw/cmssw/pull/29219.patch * https://github.com/cms-sw/cmssw/pull/29219.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#29219>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7ZULUATTEC6NZD5WTRH7AIJANCNFSM4LNXLFXA>.

[silviodonato]

merge
That line was added with #28920.
Currently if self._options.nConcurrentLumis > 1: is always true, this means we are always disabling assertLegacySafe. On contrary, before having integrated #28920 assertLegacySafe was never disabled. This fix disables assertLegacySafe only if nConcurrentLumis > 2, ie. avoid the crash of wf 1361.181 (nConcurrentLumis > 2).

cc: @schneiml

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77f869/5229/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680593
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680272
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files