Ecal laser cond tools #29228

grasph · 2020-03-18T17:43:56Z

PR description:

This PR insert a module that is used by ECAL to fill the condition database. The module is not used in this simulation or reconstruction workflow.

PR validation:

The code is used on regular basis. The compilation was tested specifically with CMSSW_10_6_9 and CMSS_11_0_1 on SLC7 before making this request.

…_deepTauVetoPCA Disabled PCA inputs for deepTau v2 (10_6_X)

…_tau-pog_deepTauVetoPCA Temporarily revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

Backport of changes from cms-sw#27988

…_1061 Fixing VID return value for HEEP Trk Iso: 10_6_X

This reverts commit 400dfeb.

Restore Disabled PCA inputs for deepTau v2 (10_6_X)

…ctionTools.py and store in custom_jme_cff.py

…_CMSSW106X DQM tau miniaod validation CMSSW_106X

Backport of cms-sw#27988 (Truncate pt of PackedCandidate)

Update master-106X to CMSSW_10_6_4_patch1

…, cfr. OverlapFilterIsoMu

…correlated DeepDoubleX taggers to make it explicit

…ggers and new explicit names for non-mass-decoreelated taggers)

Port recent pull requests to 106X

…tion database

cmsbuild · 2020-03-18T17:44:36Z

The code-checks are being triggered in jenkins.

grasph · 2020-03-18T17:46:57Z

Why are they conflict on packages I've not touched ?

cmsbuild · 2020-03-18T17:53:39Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29228/14256

This PR adds an extra 36KB to repository
Found files with invalid states:
- PhysicsTools/PatAlgos/python/jetCollectionTools.py:
  - Added: 31272fb
  - Deleted: 71616fa
- DQM/MuonMonitor/interface/CosmicMuonRecoAnalyzer.h:
  - Added: 812b438
  - Deleted: 76597c0
- Configuration/Eras/python/Modifier_run2_tau_ul_2018_cff.py:
  - Deleted: 400dfeb
  - Added: 8904eea
- SimTracker/SiStripDigitizer/python/customizeSiStripAPVDynamicGainSimulation.py:
  - Added: 6c0d50a
  - Modified: 98e933e, 21f591a, 5843d3c, 3b56923
  - Deleted: 3c1be08
- Calibration/TkAlCaRecoProducers/python/SiPixelCalSingleMuonHLTFilter_cfi.py:
  - Added: e0df03b
  - Deleted: 9a57627
- Configuration/AlCa/python/autoCond.py:
  - Modified: dd38d23, 89538fc, a7aed36, 3bbdc16, e466d38, f25b40a, 477ccd8, fbed2ac, 74382f7, 2436bbc, f0fae6e, 8a2f725, 7499880
  - Deleted: 2428563
  - Added: 3a62cbf
- DQM/MuonMonitor/src/CosmicMuonRecoAnalyzer.cc:
  - Added: 812b438
  - Deleted: 76597c0
- Configuration/Eras/python/Modifier_run2_tau_ul_2016_cff.py:
  - Deleted: 400dfeb
  - Added: 8904eea
There are other open Pull requests which might conflict with changes you have proposed:
- File CommonTools/PileupAlgos/plugins/PuppiProducer.cc modified in PR(s): PUPPI jets in RECO #28936
- File CommonTools/PileupAlgos/plugins/PuppiProducer.h modified in PR(s): PUPPI jets in RECO #28936
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update Run-3 GEM eMap in autoCond #29210
- File DQM/GEM/plugins/GEMDQMStatusDigi.cc modified in PR(s): GEM online DQM bug fix - full GE1/1 #28978
- File DQMOffline/Configuration/python/DQMOffline_SecondStep_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQMOffline/Configuration/python/DQMOffline_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): PUPPI jets in RECO #28936
- File IOPool/Input/src/RootPrimaryFileSequence.cc modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootPrimaryFileSequence.h modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootSecondaryFileSequence.cc modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootSecondaryFileSequence.h modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/genparticles_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/met_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/particlelevel_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): NanoAODv7 code updates #29212
- File PhysicsTools/PatAlgos/python/producersLayer1/tauProducer_cfi.py modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): PUPPI jets in RECO #28936, New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/tools/jetCollectionTools.py modified in PR(s): PUPPI jets in RECO #28936
- File PhysicsTools/PatAlgos/python/tools/tauTools.py modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor.h modified in PR(s): PUPPI jets in RECO #28936
- File RecoBTag/SecondaryVertex/plugins/BoostedDoubleSVProducer.cc modified in PR(s): PUPPI jets in RECO #28936
- File RecoTauTag/Configuration/python/HPSPFTaus_cff.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/Configuration/python/RecoTauTag_EventContent_cff.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/interface/DeepTauBase.h modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/plugins/DeepTauId.cc modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/src/DeepTauBase.cc modified in PR(s): New Tau ID data format #28417
- File Validation/RecoTrack/python/TrackingParticleSelectionsForEfficiency_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29228/14256/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29228/14256/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29228/14256/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29228/14256/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild and others added 30 commits September 19, 2019 17:51

Merge pull request cms-sw#27882 from cms-tau-pog/CMSSW_10_6_X_tau-pog…

3353beb

…_deepTauVetoPCA Disabled PCA inputs for deepTau v2 (10_6_X)

Revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

400dfeb

Merge pull request cms-sw#28032 from cms-sw/revert-27882-CMSSW_10_6_X…

3887146

…_tau-pog_deepTauVetoPCA Temporarily revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

Update PackedCandidate.cc

33bf3a3

Backport of changes from cms-sw#27988

Merge pull request cms-sw#27945 from Sam-Harper/HEEPVIDTrkIsoValueFix…

86c60e2

…_1061 Fixing VID return value for HEEP Trk Iso: 10_6_X

Revert "Revert "Disabled PCA inputs for deepTau v2 (10_6_X)""

8904eea

This reverts commit 400dfeb.

Fix order of era modifiers

7dcc316

Merge pull request cms-sw#28046 from fabiocos/fix27882

7ed7826

Restore Disabled PCA inputs for deepTau v2 (10_6_X)

Add customized NanoAOD content for JetMET studies

a7fb0e4

Move GenJetAdder and RecoJetAdder to a new file int PatAlgos

31272fb

Moved jetCollectionTools. Decoupled nanoAOD-based tasks from jetColle…

71616fa

…ctionTools.py and store in custom_jme_cff.py

Clone ak4PFJetsCS FastJetProducer instance. Minor fixes.

1e3ebc7

Merge pull request cms-sw#27985 from aspiezia/DQMTauMiniaodValidation…

5f41720

…_CMSSW106X DQM tau miniaod validation CMSSW_106X

Merge pull request cms-sw#28043 from rappoccio/patch-4

2574ac3

Backport of cms-sw#27988 (Truncate pt of PackedCandidate)

Merge pull request cms-sw#403 from cms-nanoAOD/branch_10_6_4_patch1

7aa43f6

Update master-106X to CMSSW_10_6_4_patch1

remove trigger object redundancy of OverlapFilterIsoEle bits 8 and 64…

7e57109

…, cfr. OverlapFilterIsoMu

Fix vtx cosTheta formula (by @amartelli)

df572f0

Add GenModel event strings to NanoAOD

ff504c3

Allow for samples without GenLumiInfoHeader product

00db1c8

Adding mass-nondecorrelated DeepDoubleX taggers; renaming the mass-de…

96ad4cc

…correlated DeepDoubleX taggers to make it explicit

renaming DeepDoubleX taggers (restoring names of mass-decorrelated ta…

c1ec278

…ggers and new explicit names for non-mass-decoreelated taggers)

changing names of MD btagDDX taggers

a2376b3

Fix ordering in nanoDQM_cfi.py

88e8de0

pt-JER and phi-JEC

845c13b

Merge pull request cms-sw#405 from cms-nanoAOD/port_1oct19_106X

6bb456c

Port recent pull requests to 106X

Add run2_nanoAOD_106Xv1 modifier

3df97f9

Activate deepTauV2p1

fe03a52

Fix ID name

6a30e98

Fix logic of era modifiers

1fb8ee6

Also treat run2_miniAOD_devel

f951302

added module used to insert ECAL laser correction sets into the condi…

31f74db

…tion database

cmsbuild added this to the CMSSW_11_1_X milestone Mar 18, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 18, 2020

grasph closed this Mar 18, 2020

grasph deleted the ecal-laser-cond-tools branch March 18, 2020 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ecal laser cond tools #29228

Ecal laser cond tools #29228

grasph commented Mar 18, 2020

cmsbuild commented Mar 18, 2020

grasph commented Mar 18, 2020

cmsbuild commented Mar 18, 2020

Ecal laser cond tools #29228

Ecal laser cond tools #29228

Conversation

grasph commented Mar 18, 2020

PR description:

PR validation:

cmsbuild commented Mar 18, 2020

grasph commented Mar 18, 2020

cmsbuild commented Mar 18, 2020