Fixes for the pMSSMFilter - backport of #28593 to 102X

[ssekmen]

PR description:

Backport of #28593 . Description from the original PR from @fabiocos :

"The PR #28201 has added a new GenFilter module, introducing anyway a problem in the IB CMSSW_11_1_X_2019-12-09-2300 as the module was erroneously places in the src directory, while now all the modules have been moved into the plugins directory.

I have taken the opportunity to turn the module into global as suggested by @makortel and fix a few coding style issues violating our rules."

PR validation:

standard tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #28593

[cmsbuild]

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ssekmen]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5262/console Started: 2020/03/18 22:57

[cmsbuild]

+1
Tested at: 2471039
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-808ccf/5262/summary.html
CMSSW: CMSSW_10_2_X_2020-03-18-1100
SCRAM_ARCH: slc6_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-808ccf/5262/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007491
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007299
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1