Making Quark-Gluon likelihood conditions DB object #2924
Conversation
|
A new Pull Request was created by @rappoccio for CMSSW_7_1_X. Making Quark-Gluon likelihood conditions DB object It involves the following packages: CondCore/JetMETPlugins @apfeiffer1, @nclopezo, @monttj, @cmsbuild, @diguida, @rcastello, @ggovi, @vadler, @Degano can you please review it and eventually sign? Thanks. |
|
|
||
| void QGLikelihoodDBReader::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) | ||
| { | ||
| std::cout << "Getting QGL objects from DB" << std::endl; |
There was a problem hiding this comment.
Could you please switch to MessageLogger here and elsewhere? This should be max. an edm::LogInfo.
There was a problem hiding this comment.
Hi, Volker,
I can for completeness, but this is a "user-level" plugin that is designed to be run by the QGL contact once in a while, but interactively with lots of debugging output. They'll always have it on, so I'm not sure that LogInfo is the way to go (since the user will always turn it on).
Cheers,
Sal
There was a problem hiding this comment.
Sal, couts will get garbled in the threaded framework while MessageLogger will be fine.
There was a problem hiding this comment.
Hi, All,
OK, I can change this then. But can I make it a warning so people will always see it? Or do I really have to make this a LogInfo (and the user will have to do the somewhat painful step of enabling it)?
Cheers,
Sal
|
Pull request #2924 was updated. @apfeiffer1, @nclopezo, @monttj, @cmsbuild, @diguida, @rcastello, @ggovi, @vadler, @Degano can you please check and sign again. |
|
Hi, Folks, Any word on this? We'd like to start the process of getting these in the DB. Thanks, |
|
+1 |
|
Hi, Folks, So, are we okay here? Cheers, |
|
+1 |
AlCa -- Making Quark-Gluon likelihood conditions DB object
This is the first attempt at translating static ROOT files (which the authors wanted to ship with CMSSW) into CondDB objects. They will be stored in QGLikelihoodObject objects. There will be further test configurations once the objects are actually in the database, but for now the only test is writing to local sqlite files and reading again. This replaces ad-hoc functionality from #2820 with a more robust strategy.