Run3-TB52 Update the geometry of the October TB and correct rotation of beam line

[bsunanda]

PR description:

Update the geometry of the first two October 2018 test beam setups of the high granularity calorimeter and also correct the rotation of the beam line

PR validation:

Tested with cfg files in SimG4CMS/HGCalTestBeam/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29242/14277

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29242/14277/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29242/14277/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29242/14278

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
IOMC/ParticleGuns
SimG4CMS/HGCalTestBeam

@SiewYan, @efeyazgan, @Dr15Jones, @mkirsano, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @agrohsje, @kpedro88, @civanch, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5273/console Started: 2020/03/19 15:15

[cmsbuild]

+1
Tested at: 8457122
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e4b3/5273/summary.html
CMSSW: CMSSW_11_1_X_2020-03-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[kpedro88]

+upgrade

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e4b3/5273/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692437
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2692097
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cvuosalo]

+1

[civanch]

+1

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
@bsunanda I see you removed several #ifdef EDM_ML_DEBUG. Did you do that on purpose?

[bsunanda]

Yes - for TB application people often use debugs in the analysis code

…

________________________________ From: Silvio Donato [notifications@github.com] Sent: 31 March 2020 10:35 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-TB52 Update the geometry of the October TB and correct rotation of beam line (#29242) +1 @bsunanda<https://github.com/bsunanda> I see you removed several #ifdef EDM_ML_DEBUG. Did you do that on purpose? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#29242 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORGMKHB6G6ZYQIX5FLRKGTLZANCNFSM4LPJEMKQ>.