New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker Alignment] All-in-one tool: fix reading of sqlite files (11.0.X) #29256
[Tracker Alignment] All-in-one tool: fix reading of sqlite files (11.0.X) #29256
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_0_X. It involves the following packages: Alignment/OfflineValidation @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please abort Apparently the tests did not run so I will restart them. |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #29255 and #28739
PR description:
It was noticed that the commit f0d34bf introduced in PR #24952 actually breaks the possibility to read SQLite files from local afs storage which is a mandatory feature of the tool. This PR reverts it.
I profit of this PR to backport as well commit 7d935d3 and a general clean-up of the example ini files in commit 0d9153a
PR validation:
As there is no unit-test in this release-cycle I locally tested the configuration to run fine.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is a combined backport of #29255 and #28739
cc:
@vbotta @connorpa @adewit