Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker Alignment] All-in-one tool: fix reading of sqlite files (11.0.X) #29256

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 20, 2020

backport of #29255 and #28739

PR description:

It was noticed that the commit f0d34bf introduced in PR #24952 actually breaks the possibility to read SQLite files from local afs storage which is a mandatory feature of the tool. This PR reverts it.
I profit of this PR to backport as well commit 7d935d3 and a general clean-up of the example ini files in commit 0d9153a

PR validation:

As there is no unit-test in this release-cycle I locally tested the configuration to run fine.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a combined backport of #29255 and #28739

cc:
@vbotta @connorpa @adewit

@mmusich
Copy link
Contributor Author

mmusich commented Mar 20, 2020

type bug-fix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_0_X.

It involves the following packages:

Alignment/OfflineValidation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title [Tracker Alignment] All-in-one tool: fix reading of sqlite files [Tracker Alignment] All-in-one tool: fix reading of sqlite files (11.0.X) Mar 20, 2020
@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@christopheralanwest
Copy link
Contributor

please abort

Apparently the tests did not run so I will restart them.

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5354/console Started: 2020/03/24 16:16

@cmsbuild
Copy link
Contributor

+1
Tested at: fb4acaf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80596a/5354/summary.html
CMSSW: CMSSW_11_0_X_2020-03-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80596a/5354/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Mar 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 51e220a into cms-sw:CMSSW_11_0_X Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants