Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastTimerService: include in the JSON file a description of the available metrics #29263

Merged
merged 1 commit into from Mar 22, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 21, 2020

PR description:

Add a section to the JSON file that lists and describes the available metrics.

PR validation:

Run as part of an HLT job.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard fwyzard changed the title Add a description of the available metrics FastTimerService: include in the JSON file a description of the available metrics Mar 21, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29263/14309

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Timer

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 21, 2020

@cmsbuild, please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 21, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5303/console Started: 2020/03/21 22:15

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: f921fe3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcd113/5303/summary.html
CMSSW: CMSSW_11_1_X_2020-03-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcd113/5303/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692131
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4612cc into cms-sw:master Mar 22, 2020
@fwyzard fwyzard deleted the FastTimerService_write_JSON_file branch May 14, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants