New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed YE3 problem #29266
Fixed YE3 problem #29266
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29266/14310
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@namapane Please note magnetic field changes in this PR. |
+1 |
Actually not... I guess you refer to Geometry/MuonCommonData/data/mf/2021/v2/mf.xml ? |
@kpedro88 , this PR was approved in the today general muon meeting. |
@namapane I understand you and Sergio are discussing the magnetic field, so that's all I wanted. |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@slomeo Phase 2 geometries that have already been used for production cannot be modified. These are: D35 (M2), D41 (M3), and D49 (M4). https://github.com/cms-sw/cmssw/tree/master/Configuration/Geometry Therefore, there are not any Phase 2 muon geometries that are still considered "in development" and open for editing. This would have to be added as a new M5 with a corresponding new detector scenario to test it. I recommend combining this small change with any other developments from the muon system (e.g. GEM/ME0 merger). |
+1 |
PR description:
Fixed YE3 (muonYoke.xml) inaccuracy for Scenario 2021
(see https://indico.cern.ch/event/894617/ )
From 22.28 cm to 23.2 cm as indicated in https://indico.cern.ch/event/61929/contributions/2053825/attachments/1002771/1426455/diskampchamber_data.pdf by @ptcox