Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed YE3 problem #29266

Merged
merged 1 commit into from Mar 23, 2020
Merged

Fixed YE3 problem #29266

merged 1 commit into from Mar 23, 2020

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Mar 22, 2020

PR description:

Fixed YE3 (muonYoke.xml) inaccuracy for Scenario 2021
(see https://indico.cern.ch/event/894617/ )

From 22.28 cm to 23.2 cm as indicated in https://indico.cern.ch/event/61929/contributions/2053825/attachments/1002771/1426455/diskampchamber_data.pdf by @ptcox

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29266/14310

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5306/console Started: 2020/03/22 11:34

@cmsbuild
Copy link
Contributor

+1
Tested at: 8998021
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6691f/5306/summary.html
CMSSW: CMSSW_11_1_X_2020-03-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6691f/5306/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 55
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692119
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

@namapane Please note magnetic field changes in this PR.

@cvuosalo
Copy link
Contributor

+1

@namapane
Copy link
Contributor

@namapane Please note magnetic field changes in this PR.

Actually not... I guess you refer to Geometry/MuonCommonData/data/mf/2021/v2/mf.xml ?
I don't know what this is intended to be, but definitely it is not used for the magnetic field.

@civanch
Copy link
Contributor

civanch commented Mar 23, 2020

@kpedro88 , this PR was approved in the today general muon meeting.

@cvuosalo
Copy link
Contributor

@namapane I understand you and Sergio are discussing the magnetic field, so that's all I wanted.

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@slomeo
Copy link
Contributor Author

slomeo commented Mar 23, 2020

@kpedro88 @civanch : For Phase II which Scenario2026 do I have to modify in order to add the new value of the YE3 thickness? My next step will be to fix the "Hidden Overlaps" for the Muon System (Scenario2021) but after that I'll start again with dd4hep and Phase II.

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 23, 2020

@slomeo Phase 2 geometries that have already been used for production cannot be modified. These are: D35 (M2), D41 (M3), and D49 (M4). https://github.com/cms-sw/cmssw/tree/master/Configuration/Geometry

Therefore, there are not any Phase 2 muon geometries that are still considered "in development" and open for editing. This would have to be added as a new M5 with a corresponding new detector scenario to test it. I recommend combining this small change with any other developments from the muon system (e.g. GEM/ME0 merger).

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants