MTD geometry: add new topology mode, adapt code to it #29270
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29270/14320
|
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/Geometry @perrotta, @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @civanch, @schneiml, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+dqm |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
+1 |
|
+1 |
|
@civanch comments? Doubts? The update to SimFastTiming is not changing anything in old scenarios, as the module type is always 0 there |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
As a follow up of #29207 and #29231 this PR adds a number of updates needed for te integration of the new ETL geometry:
a new topology mode 5
btlv1etlv5that corresponds to the latest BTL and the TDR ETL scenario D53. As this potentially breaks the one-to-one correspondence with theCrysLayoutenum ofBTLDetId, aMTDTopologyModefunction is provided to give theCrysLayoutcorresponding to a given topology mode, and the code using this correspondence is updated so as to keep the previous results unchanged;the SpecParSection names are set equal to the file names, as discussed in MTD geometry: separate BTL and ETL sensitive volume prod cuts #29231 ;
The
ETLDetId.geographicalId()method now gives back justETLDetIdas it should have already done (the type was 0 up to D50 anyway, and for D53 it is properly taken into account). The Digitization step for D53 now runs, with theBTLDeviceSimandETLDeviceSimcode adapted to the changes. We should check any other possible place where hardcoded 0 is assumed forETLDetId.modType()and fix it in case (@casarsa @gsorrentino18 FYI).As a side remark for @casarsa : likely the detId conversion in https://github.com/cms-sw/cmssw/blob/master/SimFastTiming/FastTimingCommon/src/ETLDeviceSim.cc#L42 is not needed, it should be reviewed.
PR validation:
test wf 23234.0 runs untile the end, 24434.0 runs for step1 and step2, if fails step3 as
RecoMTD/DetLayerneeds still to be adapted. The validation tests for the various MTD geometry packages run and give unchanged results for D50, and show the new topology mode (but no other change) for D53.