Fix of L1EMTF modifier for legacy16

[srimanob]

PR description:

This PR is to detach the stage2L1Trigger introduced in #29156 for L1EMTF. "stage2L1Trigger" is used for all 2016, 2017, 2018, so changing it means to change all. However, we would like to avoid the change in 2017, 2018 as Legacy program starts.

This PR is for 10_6 only. For master, we need to detach stage2L1Trigger_2017 also.

PR validation:

Dumping configurations from following workflows and compare with 10_6_10, results are expected:

• 136.731 (2016): Configuration changes as expected
• 136.788 (2017), 136.850 (2018): No change of configuration

Dump configs can be found at
/afs/cern.ch/user/s/srimanob/public/L1EMTF/afterFix

2016:

(424) ~/public/L1EMTF/afterFix: diff HLTDR2_2016_10610.py HLTDR2_2016_10611Cand2.py
15612c15612
<     Era = cms.string('Run2_2018'),
---
>     Era = cms.string('Run2_2016'),
15619c15619
<     RPCEnable = cms.bool(True),
---
>     RPCEnable = cms.bool(False),

2017, 2018

(425) ~/public/L1EMTF/afterFix: diff HLTDR2_2017_10610.py HLTDR2_2017_10611Cand2.py
(426) ~/public/L1EMTF/afterFix: diff HLTDR2_2018_10610.py HLTDR2_2018_10611Cand2.py 

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_10_6_X.

It involves the following packages:

Configuration/Eras
L1Trigger/L1TMuonEndCap

@benkrikler, @silviodonato, @cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test
thanks @srimanob

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5358/console Started: 2020/03/24 17:46

[cmsbuild]

+1
Tested at: 728eb13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c3d67/5358/summary.html
CMSSW: CMSSW_10_6_X_2020-03-24-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c3d67/5358/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 3471
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208519
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[srimanob]

@rekovic @jiafulow @abrinke1
Could you please provide the feedback on this?

What I concern is not L1Repack on data, but MC will also affect. With following cmsDriver (*) used in official MC campaign, we will get wrong config on simEmtfDigis if new release is used.

process.simEmtfDigis = cms.EDProducer("L1TMuonEndCapTrackProducer",
    BXWindow = cms.int32(2),
    CPPFEnable = cms.bool(False),
    CPPFInput = cms.InputTag("simCPPFDigis"),
    CSCEnable = cms.bool(True),
    CSCInput = cms.InputTag("simCscTriggerPrimitiveDigis","MPCSORTED"),
    CSCInputBXShift = cms.int32(-8),
    Era = cms.string('Run2_2016'),
    FWConfig = cms.bool(True),
    GEMEnable = cms.bool(False),
    GEMInput = cms.InputTag("simMuonGEMPadDigis"),
    GEMInputBXShift = cms.int32(0),
    MaxBX = cms.int32(3),
    MinBX = cms.int32(-3),
    RPCEnable = cms.bool(False),
    RPCInput = cms.InputTag("simMuonRPCDigis"),

(*)
cmsDriver.py step1 --filein "dbs:/QCD_Pt-15to7000_TuneCP5_Flat_13TeV_pythia8/RunIISummer19UL18SIM-pilot_106X_upgrade2018_realistic_v11_L1v1-v2/GEN-SIM" --fileout file:JME-RunIISummer19UL18DIGI-00002.root --mc --eventcontent RAWSIM --runUnscheduled --pileup NoPileUp --datatier GEN-SIM-DIGI --conditions 106X_upgrade2018_realistic_v11_L1v1 --step DIGI,L1,DIGI2RAW --nThreads 8 --geometry DB:Extended --era Run2_2018 --python_filename JME-RunIISummer19UL18DIGI-00002_1_cfg.py --no_exec --customise Configuration/DataProcessing/Utils.addMonitoring -n 5214 --dump_python

[jiafulow]

@srimanob I just replied to your email with the subject "Additional fix to EMTF emulation for UL2016". In short, I believe the stage2L1Trigger_EMTF2016 modifier that you created is indeed what we needed. The previous EMTF PRs were not really correct. Thanks for preparing the fix.

Regarding your message above, I did the following:

export SCRAM_ARCH=slc7_amd64_gcc700
source /cvmfs/cms.cern.ch/cmsset_default.sh
cmsrel CMSSW_10_6_X_2020-03-24-1100
cd CMSSW_10_6_X_2020-03-24-1100/src
cmsenv

git cms-merge-topic srimanob:10_6_FixL1EMTFModifierForLegacy16
scram b

and ran the cmsDriver command that you provided. In the "dump" python cfg file, this is what I see:

$ python -i JME-RunIISummer19UL18DIGI-00002_1_cfg.py 
>>> process.simEmtfDigis.Era
cms.string('Run2_2018')
>>> process.simEmtfDigis.RPCEnable
cms.bool(True)

This is the correct behavior for MC with era=Run2_2018. So I think the PR is good. Is there anything that I'm missing?

[srimanob]

@jiafulow Thanks for confirmation
@rekovic @silviodonato If you agree, I think we can go ahead then, for CANDIDATE3. Thanks.

[silviodonato]

merge
@rekovic please let me know if you have any objections

[rekovic]

+1

[rekovic]

thanks @srimanob