Backport of #29257 (Add QGL input variables and update jerc variables in JME Custom-NanoAODs) to 10_6_X

[nurfikri89]

Backport from #29257

This PR involves the following changes:

1. Add input jet variables needed for the quark vs gluon likelihood (QGL) in the JME Custom-NanoAODs. The variables are useful QGL developers when they need to train the likelihood for future new releases. The input variables are already calculated together with the QGL discriminant in the main NanoAOD production. They are not saved in the main NanoAODs by default. Previous (closed) PR for this is Add QGL input variables in JME Custom-NanoAODs #29239.

2. Remove deprecated "jerc" variables and add new ones in line with the latest jets_cff.py. This fix is for issue PhysicsTools.NanoAOD.custom_jme_cff needs to be updated #29245.

if this PR is a backport please specify the original PR:

Original PR is #29257

[cmsbuild]

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Add QGL input variables and update jerc variables in JME Custom-NanoAODs #29257

[nurfikri89]

FYI JMAR convenors @alefisico @camclean

[peruzzim]

I think we need the backport of NanoAODv7 content to come to 10_6_X before this, I will take care of that

[nurfikri89]

@peruzzim ah apologies. Didn't realize that it hasn't been backported yet. Will wait for the backport.

[perrotta]

hold
(while waiting for the backport of NanoAODv7 content, see #29290 (comment))

[cmsbuild]

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[perrotta]

@peruzzi any news about the backport of nanoAOD v7 in 10_6, so that we can move on here?

[silviodonato]

do you have any news @peruzzim ?

[perrotta]

backport of #29257

[camclean]

@peruzzim any updates?

[silviodonato]

Any news from xpog @fgolf @peruzzim?

[silviodonato]

@peruzzim?

[perrotta]

(Now removed "-1")
This is unattended since long time already: we will return to it as soon as there will be any development that allow us finalizing the review

[silviodonato]

I think we need the backport of NanoAODv7 content to come to 10_6_X before this, I will take care of that

do you have any news? @peruzzim

[perrotta]

unhold

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #31063,cms-data/PhysicsTools-NanoAOD#12
Test Parameters:

• MATRIX_EXTRAS = 1325.7,1325.6,136.8521,1325.8,136.7722,1329.1,136.7952,25202.01
• CMSSW_10_6_X_2020-08-10-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8688/console Started: 2020/08/10 16:11

[cmsbuild]

+1
Tested at: 4a8bcfe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c249/8688/summary.html
CMSSW: CMSSW_10_6_X_2020-08-10-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c249/8688/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 213 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214602
• DQMHistoTests: Total failures: 36
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3214229
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 9.379 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 9.379 KiB Physics/NanoAODDQM
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[perrotta]

+1

• It updates custom_jme_cff following the removal of jetTable.variables.jercCHPU made by the backport of nanoAODv7 content (which was awaited for) implemented in NanoAODv7 code updates [106X] #31063
• It adds input jet variables needed for the quark vs gluon likelihood in the JME Custom-NanoAODs, whose physics related evaluation is left to xpog and analysis
• Jenkins tests pass and show no differences in the standard workflows besides those originated by running this PR in contemporary with NanoAODv7 code updates [106X] #31063
• From the reco point of view this PR is ok for being backported; final word on it will come from xpog, though

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #31124,#31063,cms-data/PhysicsTools-NanoAOD#12
Test Parameters:

• MATRIX_EXTRAS = 10224.15,1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521
• CMSSW_10_6_X_2020-08-12-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8735/console Started: 2020/08/12 22:13

[cmsbuild]

-1
@nurfikri89 This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29290/8735/git-merge-result

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #31124,#31063
Test Parameters:

• MATRIX_EXTRAS = 10224.15,1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521
• CMSSW_10_6_X_2020-08-14-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8756/console Started: 2020/08/14 14:39

[cmsbuild]

-1
@nurfikri89 This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29290/8756/git-merge-result

[nurfikri89]

Closing this PR as #31124 will supersede the changes made here.