TOP DQM: Fixed MuonRelIso

[kuyoun]

PR description:

Fixed MuonRelIso (filled twice for miniAOD)

Applied loose isloation cut for muon

PR validation:

Local test was done; cleaned unused lines and change minor things

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29309/14382

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29309/14382/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29309/14382/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

@kuyoun I am assuming you are Youn Jung Roh since we don't have your github username identified in:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#TOP
Please include the PAG (TOP) name in the PR name and make a proper description of the PR: why do you need to change this and what changes you expect.
Besides you have code style and quality issues to fix. Thanks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29309/14390

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @kuyoun for master.

It involves the following packages:

DQM/Physics

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kuyoun]

While do validation check, auto checker keeps pointed out "discrepancy on MuonRelIso for miniAOD". It is because histo was filled twice.

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5400/console Started: 2020/03/26 15:21

[cmsbuild]

+1
Tested at: 52130f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865a6f/5400/summary.html
CMSSW: CMSSW_11_1_X_2020-03-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29309/14590

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #29309 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5604/console Started: 2020/04/08 17:15

[cmsbuild]

+1
Tested at: 3cd413b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865a6f/5604/summary.html
CMSSW: CMSSW_11_1_X_2020-04-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865a6f/5604/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 788
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691003
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1