New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HGCal_disableNoise customization function #29329
Conversation
The logic with which the parameters are parsed requires the presence of many parameters that were not present in the customization function.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29329/14401
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages: SimCalorimetry/HGCalSimProducers @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The logic with which the parameters are parsed requires the presence of
many parameters that were not present in the customization function.
PR validation:
Tested on workflow 23234, with and without the customization function. The code works and the Noise is turned off with the customization active.