Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BasicGenValidation_cff.py #29352

Merged
merged 1 commit into from Apr 1, 2020
Merged

Update BasicGenValidation_cff.py #29352

merged 1 commit into from Apr 1, 2020

Conversation

menglu21
Copy link
Contributor

PR description:

Backport from #29146

PR validation:

Procedure:
scram project CMSSW_7_1_45 & cmsenv
git cms-rebase-topic --old-base CMSSW_11_1_0_pre5 menglu21:master
git branch -m portFrom111XTo71X_genvalidation
then do the same things with original PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

Original PR is #29146

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

A new Pull Request was created by @menglu21 (Meng_Lu) for CMSSW_7_1_X.

It involves the following packages:

Validation/EventGenerator

@SiewYan, @andrius-k, @mkirsano, @kmaeshima, @schneiml, @efeyazgan, @cmsbuild, @jfernan2, @agrohsje, @fioriNTU, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

backport of #29146

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5461/console Started: 2020/03/31 15:43

@cmsbuild
Copy link
Contributor

+1
Tested at: 60a8cf6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-792265/5461/summary.html
CMSSW: CMSSW_7_1_X_2020-03-29-0000
SCRAM_ARCH: slc6_amd64_gcc481

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-792265/5461/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682523
  • DQMHistoTests: Total failures: 3111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 679038
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Mar 31, 2020

+1

@jfernan2
Copy link
Contributor

+1
There are 3111 failures and -10kB, I guess that unrelated to this PR since they are in the DQM/TimerService

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

please test
to refresh the comparison results

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5479/console Started: 2020/04/01 10:02

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+1
Tested at: 60a8cf6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-792265/5479/summary.html
CMSSW: CMSSW_7_1_X_2020-03-29-0000
SCRAM_ARCH: slc6_amd64_gcc481

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-792265/5479/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682523
  • DQMHistoTests: Total failures: 2889
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 679260
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 1, 2020

The failures are repited. As far as I can see from RelMon they include CASTOR and DQM (TimerService) folders, might they be realted to the CMSW 71X version?

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

@jfernan2 I made an issue #29365 to keep track of the difference. Indeed we had these fake errors since a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants