Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect L1T producers against ME0 hits #29369

Merged
merged 2 commits into from Apr 13, 2020
Merged

Protect L1T producers against ME0 hits #29369

merged 2 commits into from Apr 13, 2020

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 1, 2020

PR description:

Coincidence pads nor pad clusters will be built for ME0. This PR prevents two L1T producers from using ME0 digis. This is done in preparation of the merger of GEM and ME0.

PR validation:

I ran WF 22034.0 successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@watson-ij @jshlee

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29369/14472

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives
L1Trigger/L1TGEM

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29369/14473

  • This PR adds an extra 16KB to repository

@silviodonato
Copy link
Contributor

Kind reminder @rekovic (this change is rather small)

@rekovic
Copy link
Contributor

rekovic commented Apr 13, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5677/console Started: 2020/04/13 17:47

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: d17d7dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4a12/5677/summary.html
CMSSW: CMSSW_11_1_X_2020-04-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@jshlee
Copy link
Contributor

jshlee commented Apr 13, 2020

@dildick protecting for the 16 eta partitions would be handy too

@dildick
Copy link
Contributor Author

dildick commented Apr 13, 2020

@jshlee Idd. But I would put that in a different PR.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4a12/5677/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2695166
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694808
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 64a6bd5 into cms-sw:master Apr 13, 2020
@dildick dildick deleted the from-CMSSW_11_1_X_2020-03-31-1100-Protect-L1T-producers-against-ME0-hits branch April 15, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants