Fix MET Significance, Covariance Matrix and unclustered energy lepton subtraction

[ahinzmann]

PR description:

Resolve issue #25849

selectedPatLeptons have no sourceCandidatePtrs linked to them.
Therefore lepton subtraction from unclustered energy fails in METSignficance.cc.
slimmedLeptons have properly linked sourceCandidatePtrs and allows lepton subtraction from unclustered energy.
This resulted in a disagreement between MET significance, unclustered energy and covariance matrix stored in MiniAOD and recomputed out of MiniAOD.
The value in MiniAOD was wrong and is now fixed by converting electrons/photons into candidates with sourceCandidatePtrs when running on RECO.

PR validation:

It was checked that METSignficance.cc now sees all the lepton PF candidates, which were previously not seen on workflow 136.8311.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport to 106X for UL re-miniAOD in #29392.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29385/14500

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py modified in PR(s): PUPPI MET in RECO #29254

[cmsbuild]

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/PatUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @emilbols, @gouskos, @jdolen, @smoortga, @riga, @schoef, @rappoccio, @mariadalfonso, @JyothsnaKomaragiri, @nhanvtran, @gpetruc, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @mverzett, @andrzejnovak, @peruzzim, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[ahinzmann]

I push one more commit that sorts our the remaining differences observed in #29254.
This PR now gives identical unclustered PF+PUPPI energy and uncertainty as this PR+#29254.
Let's merge this PR before #29254.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29385/14515

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py modified in PR(s): PUPPI MET in RECO #29254

[cmsbuild]

Pull request #29385 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5527/console Started: 2020/04/04 04:07

[slava77]

but do we need to backport all of this?
In practice that means a lot of manual backporting (since 106 and 102 don't have code-format applied)

I'm not sure which code-format is implied.
Most of this PR by line is new code.
There was no code-format in python, where most of the (perhaps questionable) perturbation happened in this PR.
The current master-102X diff in runMETCorrectionsAndUncertainties.py is rather minimal, which means that a backport to 102X should be almost the same as a diff introduced in this PR.

[cmsbuild]

+1
Tested at: 5f8cb30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-737fc6/5665/summary.html
CMSSW: CMSSW_11_1_X_2020-04-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-737fc6/5665/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 258 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2695166
• DQMHistoTests: Total failures: 92
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694755
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29385 5f8cb30

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show differences only in miniAOD workflows in slimmedMETsPuppi and slimmedMETs variables, in line with the updates in this PR

[slava77]

@silviodonato
please check this PR.
This is standing in the way of integration of #29254.
Thank you.

[silviodonato]

merge
@santocch

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.