New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unit test to check for clang-tidy changes #29395
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29395/14524
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29395/14527
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: Utilities/ReleaseScripts @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29395/14528
|
The tests are being triggered in jenkins. |
Pull request #29395 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR runs clang-tidy and make sure the generated yaml files format is not changed. This could happen with new version of llvm. As it happened with llvm 9.0.1 but our build system did not noticed it. This broke clang-tidy in CMSSW_11_1_X (with LLVM 9). cms-sw/cmsdist#5721 fixes the build rules to work with llvm 9.0.1 but we think it would be help help top have a unit test which makes sure that we catch such issues at the time of llvm integration.
Local build and test run successfully.