Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6 backport] Define proper BS for 2018 premixing workflow if starting from scratch #29402

Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Apr 7, 2020

PR description:

To fix the bug of 2018 premixing wf if start from scratch. BS of 2017 was used. It seems normally, PdmV uses GS from StandardPU wf where BS is handled properly, so the issue has never been spotted. This is to keep the proper configuration of legacy release.

PR validation:

runTheMatrix.py --what premix -l 250200.18 --wm init
provides proper configuration

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #29401, to keep the proper configuration of Legacy release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_10_6_X.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 8, 2020

please test

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 8, 2020

backport of #29401

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5610/console Started: 2020/04/08 22:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+1
Tested at: 6bcea02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836977/5610/summary.html
CMSSW: CMSSW_10_6_X_2020-04-08-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836977/5610/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2704 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 94402
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3117587
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.117 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@chayanit
Copy link

chayanit commented Apr 9, 2020

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 9, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ee772d4 into cms-sw:CMSSW_10_6_X Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants