Phase1 Tracker: Added rails, Shrinked outermost shield, Added TBPX inter-flanges support tubs #29441
Conversation
… + Place shield at lower radius, Rout = 186 mm.
… flanges. Added those 8 tubes (placed slightly lower than EM shield).
…ezoid. There is no support for prism in CMSSW, so I just consider a prism as a degenerate trapezoid. Upper width needs to be non null in a trapezoid to be supported by G4, so set it to 1 um (which also corresponds better to mechanical reality anyway!).
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29441/14606
|
|
A new Pull Request was created by @ghugo83 for master. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 887da09 CMSSW: CMSSW_11_1_X_2020-04-09-1100 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log20434.0 step3 runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log23234.0 step3 runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log21234.0 step3 runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
Problem is not connected with this PR |
|
This PR changes the Phase 1 tracker XML. Does this change affect Run 2? |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@mmusich We aim to complete all geometry XML changes for Run 3 in CMSSW 11_1. After all the changes are complete, then I would create the new geometry DB payloads. |
|
@cvuosalo if we had these changes in DB right now, we would gladly ask production of samples to validate the change against data. As it is missing it's a showstopper. |
|
@mmusich How many validation campaigns would you like to run on this series of geometry changes? We have more changes to the geometry XML coming soon. I was assuming that there would be only one validation of the new geometry after all the changes were completed. Also, we are still doing our own internal checking of these changes. |
|
@cvuosalo this change is the main one regarding the Tracker geometry and it is also the only one we can actually validate beforehand by comparison with Run2 data, so in that sense is a bit "special" as it is more of a bug-fix than an update. I guess we can wait for the availability of 11_1_0 assuming it will contain the right DB tags in Global Tag. |
|
@cvuosalo , @mmusich , we need to complete XML for Run3. beam-pipe and pps are two main components , which are not yet included into XML, there are also questions to materials description. For many reasons, including what you said, we need to make DB for Run3 asap, not waiting to the end of 11_1_0 cycle. |
This fixes a mismatch between 2018 data and CMSSW Phase 1 Tracker description, as described at: https://indico.cern.ch/event/886623/contributions/3743154/attachments/1994728/3327417/2020.02.27_MaterialBudget_kropiv.pdf
From data (2018D Single Mu PD):
From framework geometry:
What was changed, with info from Mechanics team:
New Phase 1 Tracker geometry in framework:
(XY) section at Z=0:
Profile around Barrel:
NB 1: Obvisouly, 'Phase 0' Tracker not modified.
There is also a version of Phase 2 Outer Tracker which is plugged on a Phase 1 Inner Tracker. I had done that description at a time where we did not have any Phase 2 Inner Tracker design / description yet. This description is kept for reference only, hence was of course not modified either.
NB 2: I have not done nor looked at the rest of the Phase 1 Tracker description, so discard any responsibility from it :)
NB 3: Do not have info on brackets, inserts, screws and pins, not added here.
PR tests:
No G4 error with new shapes + Checked there is still 0 overlap on both reference and migrated Phase 1 Tracker geometry.