Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTriggerOffline/Egamma DQMEDAnalyzer migration #2945

Merged
merged 4 commits into from Mar 27, 2014

Conversation

thomreis
Copy link
Contributor

Migration of the HLTriggerOffline/Egamma HLT validation code to DQMEDAnalyzer for thread safe operation.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_7_1_X.

HLTriggerOffline/Egamma DQMEDAnalyzer migration

It involves the following packages:

HLTriggerOffline/Egamma

@danduggan, @ojeda, @rovere, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 26, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@Dr15Jones
Copy link
Contributor

Has this module been checked to be sure it doesn't call any thread-unsafe methods of the DQMStore?

@thomreis
Copy link
Contributor Author

The harvesting module EmDQMPostProcessor is unchanged but the rest has been updated to use the IBooker.

nclopezo added a commit that referenced this pull request Mar 27, 2014
HLTriggerOffline/Egamma -- DQMEDAnalyzer migration
@nclopezo nclopezo merged commit 8f4573b into cms-sw:CMSSW_7_1_X Mar 27, 2014
@thomreis thomreis deleted the dqmedanalyzer_migration branch March 27, 2014 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants