Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixel Payload Inspector: Gain Calibration #29481

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 15, 2020

PR description:

This PR adds basic monitoring classes for inspection of payloads of the type SiPixelGainCalibrationOffline and SiPixelGainCalibrationForHLT condition formats.
Testing scripts are provided as well.
Below is couple of examples:

image

image

PR validation:

Relies on the existing (augmented) unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is needed.
cc:
@tsusa @tvami

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14685

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14686

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14728

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29481 was updated. @ggovi, @cmsbuild can you please check and sign again.

@silviodonato
Copy link
Contributor

@ggovi do you have any comments?

@mmusich
Copy link
Contributor Author

mmusich commented Apr 20, 2020

can at least tests be started here?

@ggovi
Copy link
Contributor

ggovi commented Apr 20, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5795/console Started: 2020/04/20 22:45

@cmsbuild
Copy link
Contributor

+1
Tested at: 88c0835
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f527ca/5795/summary.html
CMSSW: CMSSW_11_1_X_2020-04-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f527ca/5795/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696115
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Apr 21, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 11f0e30 into cms-sw:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants