New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixel Payload Inspector: Gain Calibration #29481
SiPixel Payload Inspector: Gain Calibration #29481
Conversation
…using templates, update tests and unit tests
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14685
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14686
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiPixelPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29481/14728
|
@ggovi do you have any comments? |
can at least tests be started here? |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds basic monitoring classes for inspection of payloads of the type
SiPixelGainCalibrationOffline
andSiPixelGainCalibrationForHLT
condition formats.Testing scripts are provided as well.
Below is couple of examples:
PR validation:
Relies on the existing (augmented) unit tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport and no backport is needed.
cc:
@tsusa @tvami