Phase2-hgx235 Rearrange the files to enable both DDD and DD4Hep to work

[bsunanda]

PR description:

Rearrange the files to enable both DDD and DD4Hep to work

PR validation:

Use standard runTheMatrix.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29482/14689

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/ForwardCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5706/console Started: 2020/04/15 18:55

[cmsbuild]

+1
Tested at: b153341
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6cb6/5706/summary.html
CMSSW: CMSSW_11_1_X_2020-04-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cvuosalo]

@bsunanda Will this PR fix the zHGCalEE1 error Sergio encountered?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6cb6/5706/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696112
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cvuosalo]

@bsunanda Why does the hfnose1 directory have:

v0
v1
v1a
v2
v3

and this PR adds v1a? Shouldn't you add new directories in numeric sequence?

[bsunanda]

I don't think it will fix any thing. I do not see the error which Sergio sees. Of course I did not try sim step - but I access the parameters defined in hgcalCons in all Phase2 scenario.

I named v1a which is v1 corrected while v3 is v2 corrected. May be I should name them v1c and v2c. Please suggest

[cvuosalo]

@bsunanda Are you saying there are two parallel lines of development?
v0 -> v1 -> v1a
and
v0 -> v1-> v2 -> v3
So both v1a and v3 would be in use?

[bsunanda]

@cvuosalo You are absolutely right: v0->v1->v1a and v0->v1->v2->v3 so 2 versions will be there for the ones used: v1a and V3

[cvuosalo]

@bsunanda I don't think the versioning scheme foresaw parallel lines of development. How about creating two directories with explanatory names in the hfnose directory, one for the v1 -> v1a line and one for the v2 -> v3 line? These two directories would then contain simple v1, v2, etc. directories. In this way, the parallel lines of development would be reflected in the directory structure.

[bsunanda]

@cvuosalo v0->v1->v1a is not a development line. This is created just to compare the v1 version to work with dd4hep. The development cycle will be v1->v2->v3. It will most likely soon become v4. They are not parallel. v1a is made just to have the older version alive with dd4hep and this version is widely used for the studies at the moment.

[cvuosalo]

+1

[kpedro88]

+upgrade
no changes observed in any phase 2 workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1