re-add also SiPixelPhase1RecHitsAnalyzer to DQM offline for HI scenario

[mmusich]

PR description:

While reviewing the code for PR #29461 I noticed also that some other DQM modules (SiPixelPhase1RecHitsAnalyzer) were excluded from being run without apparent reason.
I re-add it here, together with the harvester for the residuals.

PR validation:

Standard limited matrix integration tests passed +

runTheMatrix.py -l 150.0 -t 4 -j 8

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29495/14729

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/SiPixelPhase1Config

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5729/console Started: 2020/04/16 18:46

[cmsbuild]

+1
Tested at: d7956a5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-300c2b/5729/summary.html
CMSSW: CMSSW_11_1_X_2020-04-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-300c2b/5729/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696112
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

Let me add in cc @fioriNTU who added those lines long time ago with #20496.

[fioriNTU]

Let me add in cc @fioriNTU who added those lines long time ago with #20496.

@silviodonato and @mmusich, sorry I should have commented before, but I simply forgot. I do not remember why I excluded the residuals plugin form HI, sorry. For the RecHit plugin, I did it, because probably at that time the code was doing exactly the same things done by the TrackCluster plugin, but my memory is not that strong in general :-)
Anyway, in that PR, I added for the first time the HI processing sequence in PixelPhase1, which was not available yet. So, probably I had some weird crash for the residuals plugin, and I simply decided that was enough without. Then, as far as I remember, for the last HI run we have used the pp configuration, so probablly nobody touched that code anymore because is obsolete in production (but maybe not in Validation). Hope this helps.

[mmusich]

Indeed the only wf which uses this is 150.0. This is not meant for production but as long as this scenario is supported in release should be monitored.

[silviodonato]

+1