Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up filesFromList and filesFromDASQuery in ConfigBuilder.py [102X] #29500

Merged
merged 2 commits into from Apr 18, 2020

Conversation

kpedro88
Copy link
Contributor

backport of #29454

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_2_X.

It involves the following packages:

Configuration/Applications

@cmsbuild, @silviodonato, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5734/console Started: 2020/04/16 20:45

@cmsbuild
Copy link
Contributor

+1
Tested at: ca45cfa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b298c7/5734/summary.html
CMSSW: CMSSW_10_2_X_2020-04-16-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b298c7/5734/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007544
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007351
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d2d4651 into cms-sw:CMSSW_10_2_X Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants