Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM Checking if ME exists after getting it in harvesting #29506

Conversation

andrius-k
Copy link

@andrius-k andrius-k commented Apr 17, 2020

PR description:

reportSummaryMapPreliminary ME is booked conditionally in reco step but assumed to exist in harvesting. Added a check to use ME in harvesting only if it was created in reco.

PR validation:

PR was validated locally.

ME is booked conditionally in reco but assumed to exist in harvesting.
Added a check to use ME in harvesting only if was created in reco.
@andrius-k
Copy link
Author

please test

@andrius-k
Copy link
Author

ping

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29506/14752

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #29372,#29493,#29484
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5750/console Started: 2020/04/17 14:04

@cmsbuild
Copy link
Contributor

+1
Tested at: 3ded797
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43db62/5750/summary.html
CMSSW: CMSSW_11_1_X_2020-04-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43db62/5750/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696078
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #29372,#29493,#29484
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5777/console Started: 2020/04/20 11:37

@cmsbuild
Copy link
Contributor

+1
Tested at: 3ded797
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e50829/5777/summary.html
CMSSW: CMSSW_11_1_X_2020-04-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e50829/5777/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696091
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@andrius-k
Copy link
Author

This PR fixes a failing new unit tests: #29372 (comment) and, if there are no objections, can be merged.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c9b8cc7 into cms-sw:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants