Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean buildfiles after L1TriggerOffline in alphabet #29541

Merged
merged 1 commit into from Apr 27, 2020
Merged

Clean buildfiles after L1TriggerOffline in alphabet #29541

merged 1 commit into from Apr 27, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #29485), this time covering all subsystems that come after Reco in the alphabet.

This one mainly focuses on the few subsystems that are between L1TriggerOffline and Reco in the alphabet. It also does what was promised in #29485 (comment): removing the library export of two header-only packages.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29541/14823

  • This PR adds an extra 88KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CondCore/DBOutputService
MagneticField/Engine
MagneticField/GeomBuilder
MagneticField/Layers
MagneticField/ParametrizedEngine
MagneticField/Records
MagneticField/UniformEngine
MuonAnalysis/MomentumScaleCalibration
MuonAnalysis/MuonAssociators
OnlineDB/CSCCondDB
OnlineDB/EcalCondDB
OnlineDB/SiStripConfigDb
OnlineDB/SiStripESSources
OnlineDB/SiStripO2O
PerfTools/EdmEvent
PhysicsTools/CondLiteIO
PhysicsTools/FWLite
PhysicsTools/JetCharge
PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/MVAComputer
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/RecoUtils
PhysicsTools/SelectorUtils
PhysicsTools/TensorFlow
PhysicsTools/UtilAlgos
PhysicsTools/Utilities
QCDAnalysis/Skimming
QCDAnalysis/UEAnalysis
RecoCaloTools/Selectors
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoTracker/TkNavigation
SimG4CMS/CherenkovAnalysis
SimG4CMS/HcalTestBeam
Validation/GlobalDigis

@perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @makortel, @schneiml, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch, @tocheng can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @gouskos, @felicepantaleo, @jainshilpi, @hatakeyamak, @emilbols, @argiro, @ahinzmann, @lgray, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @JyothsnaKomaragiri, @makortel, @smoortga, @peruzzim, @jhgoh, @dgulhan, @jdolen, @HuguesBrun, @cericeci, @ferencek, @trocino, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @tocheng, @schoef, @mschrode, @ebrondol, @fabiocos, @clelange, @namapane, @riga, @battibass, @Fedespring, @calderona, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @mmusich, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5832/console Started: 2020/04/23 08:07

@cmsbuild
Copy link
Contributor

+1
Tested at: 4c3ebc2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd15e8/5832/summary.html
CMSSW: CMSSW_11_1_X_2020-04-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd15e8/5832/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696113
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Apr 23, 2020

+1

for #29541 4c3ebc2

@makortel
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Apr 24, 2020

+1

@pohsun
Copy link

pohsun commented Apr 26, 2020

+1

@guitargeek
Copy link
Contributor Author

Hi @silviodonato, just the same reminder as in #29295 (comment): the db-pending tag is not really used anymore for about least half a year, so probably this PR can be merged now.

@silviodonato
Copy link
Contributor

merge
FYI @ggovi

@cmsbuild cmsbuild merged commit 69a5a2f into cms-sw:master Apr 27, 2020
@guitargeek guitargeek deleted the deps_after_L1Trigger branch April 27, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants