New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean buildfiles after L1TriggerOffline in alphabet #29541
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29541/14823
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CondCore/DBOutputService @perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @makortel, @schneiml, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1
|
+1 |
+1 |
+1 |
Hi @silviodonato, just the same reminder as in #29295 (comment): the |
merge |
PR description:
Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #29485), this time covering all subsystems that come after Reco in the alphabet.
This one mainly focuses on the few subsystems that are between L1TriggerOffline and Reco in the alphabet. It also does what was promised in #29485 (comment): removing the library export of two header-only packages.
PR validation:
CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with
git grep
.