Fireworks 11_1_X: Fix crash on use of non-default palette (forward port)

[alja]

This PR is forward port of #29540.

[alja]

+1

[cmsbuild]

@alja, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[silviodonato]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824

* This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

* **code-format**:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824/code-format.patch
  e.g. `curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14824/code-format.patch | patch -p1`
  You can also run `scram build code-format` to apply code format directly

You need to apply the code-checks fixes in order to proceed with the PR tests

[silviodonato]

@alja

[alja]

+1

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29542/14839

• This PR adds an extra 24KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5842/console Started: 2020/04/23 22:53

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Core

@cmsbuild can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: aafb03c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1789d7/5842/summary.html
CMSSW: CMSSW_11_1_X_2020-04-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[silviodonato]

+1