Make DQMRootOutputModule to depend on all DQM modules via DQMTokens

[makortel]

PR description:

#29553 implies that all data dependencies for modules in Tasks must be specified to keep those modules alive and running (in principle the proper dependencies should be declared anyway, that PR makes it necessary also in practice). It turned out that the DQMRootOutputModule currently does not declare dependencies on all the DQM analyzers. Easiest fix is to do consumesMany<DQMToken, ...> for both Lumi and Run products.

Actually I tried first to use the outputCommands (which by the for some reason is

cmssw/Configuration/EventContent/python/EventContent_cff.py

Lines 356 to 357 in 3f89112

	outputCommands = cms.untracked.vstring('drop *',
	'keep *_MEtoEDMConverter_*_*'),

which to me doesn't seem to make much sense), but that would require making DQMToken persistable, which would require an underscore a forbidden character for all modules producing DQMToken. An underscore appears to be in wide use for DQM modules, which is why I scrapped that approach (I did some amount of migration to no-underscore module labels, if DQM is interested I can make pull request(s) of what I did).

PR validation:

Limited matrix runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[makortel]

FYI @schneiml

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29586/14911

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQMServices/FwkIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5907/console Started: 2020/04/29 18:04

[cmsbuild]

+1
Tested at: 0e73855
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0de182/5907/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0de182/5907/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696113
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[schneiml]

@makortel uh, so I was wrong?

Thanks a lot, anyways!