Do not force creation of StreamerInfos at ROOT file opening #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing the creating of StreamerInfos at file open is no longer needed and it causes problems when we have done a 'drop on input' for a file and the items dropped can not be schema evolved. In that case the original code would cause an exception and it would kill the job. This change allows us to properly handle 'drop on input'.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_THREADED_X. Do not force creation of StreamerInfos at ROOT file opening It involves the following packages: IOPool/Input @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_THREADED_X IBs unless changes or unless it breaks tests. |
ktf
added a commit
that referenced
this pull request
Mar 21, 2014
Do not force creation of StreamerInfos at ROOT file opening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing the creating of StreamerInfos at file open is no longer needed
and it causes problems when we have done a 'drop on input' for a file
and the items dropped can not be schema evolved. In that case the original
code would cause an exception and it would kill the job. This change
allows us to properly handle 'drop on input'.