Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgc slhc9 #2967

Merged
merged 13 commits into from Mar 25, 2014
Merged

Hgc slhc9 #2967

merged 13 commits into from Mar 25, 2014

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Mar 22, 2014

Splitting up sensitive detector for HGCEE {front,back} (silicon, scintillator)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

Hgc slhc9

It involves the following packages:

Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HGCalSimData
SimG4Core/Application

The following packages do not have a category, yet:

Geometry/HGCalSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2967 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@pfs
Copy link
Contributor Author

pfs commented Mar 22, 2014

There is some overlap with #2957 from @vandreev11 - this pull includes the xml files plus some modifications to OscarProducer needed for HGCal

@ianna
Copy link
Contributor

ianna commented Mar 24, 2014

+1

@cmsbuild
Copy link
Contributor

Pull request #2967 was updated. @civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please check and sign again.

@mark-grimes
Copy link

merge

Digitisation still fails in Geometry/CaloGeometry/interface/EZMgrFL.h line 37 with the same assertion.
Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Mar 25, 2014
@cmsbuild cmsbuild merged commit 1bc6844 into cms-sw:CMSSW_6_2_X_SLHC Mar 25, 2014
@pfs pfs deleted the hgc_slhc9 branch November 18, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants