DQM: Use correct local MEs in DQMEDAnalyzer

[schneiml]

PR description:

This is an attempt to fix #29743.

I added these calls as a precaution (there might be cases where user can can see invalid MEs otherwise) and got the code from DQMOneEDAnalyzer. Except DQMEDAnalyzer needs a different definition of moduleid... And screwing that up could lead to a thread safety problem like observed, since now we get enter/init lumi on different threads for the same MEs, and depending on the interleaving the set of MEs might have changed between initLumi and enterLumi, leading to the assertion failure.

This is a theory only though.

PR validation:

None, so far.

I can't reproduce the issue in #29743, so I can't tell if this fixes the issue. But it is very obviously a bug, and fixing it should not hurt.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29745/15174

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQMServices/Core

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[schneiml]

please test

This does not really prove anything about the issue, but at least shows that there is nothing seriously wrong.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6133/console Started: 2020/05/06 10:59

[smuzaffar]

@schneiml , I locally tested this with all the failing workflows (using -t4) and all ran fine

runTheMatrix.py -i all -t 4 --ibeos -l 4.52,122.0,134.811,136.732,136.87,1362.18,4008.0,11650.0,12634.0,25211.18,25212.17,25403.0,250205.0,250208.18 
14 14 14 11 3 tests passed, 0 0 0 0 0 failed

[cmsbuild]

+1
Tested at: da571c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f916c5/6133/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[silviodonato]

merge

[smuzaffar]

@silviodonato , I am going to start a 13h00 IB now to get this change in

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f916c5/6133/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697206
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1
Just for the records....

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.