Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added remaining files for 2021 xml geometry (beampipe and pps) #29754

Merged
merged 3 commits into from May 8, 2020

Conversation

civanch
Copy link
Contributor

@civanch civanch commented May 6, 2020

PR description:

Added missing files for 2021 xml

PR validation:

local private test

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented May 6, 2020

@cvuosalo , @ianna, please, check if I miss something. This is not final 2021 xml but the draft of it.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29754/15188

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented May 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6143/console Started: 2020/05/06 21:11

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: 46283d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e98f58/6143/summary.html
CMSSW: CMSSW_11_1_X_2020-05-06-1300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e98f58/6143/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697183
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29754/15220

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Pull request #29754 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented May 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6169/console Started: 2020/05/08 09:41

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+1
Tested at: 72cdbdf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e98f58/6169/summary.html
CMSSW: CMSSW_11_1_X_2020-05-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e98f58/6169/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697189
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented May 8, 2020

+upgrade

@civanch
Copy link
Contributor Author

civanch commented May 8, 2020

+1

@cvuosalo , we discuss this today, better to merge asap

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cvuosalo
Copy link
Contributor

cvuosalo commented May 8, 2020

+1

@silviodonato silviodonato changed the title added remaining files for 2021 xml added remaining files for 2021 xml geometry (beampipe and pps) May 8, 2020
@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b0cd0a into cms-sw:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants