Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead assignments in L1TStage2RegionalMuonCandComp L1 muon DQM module. #29766

Merged
merged 1 commit into from May 8, 2020

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented May 7, 2020

PR description:

Fixes two dead assignments found by the static analyzer. The BMTF dxy and pt2 tests should happen before the summary histogram is filled.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_11_1_X_2020-05-06-2300/slc7_amd64_gcc820/llvm-analysis/report-721356.html
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_11_1_X_2020-05-06-2300/slc7_amd64_gcc820/llvm-analysis/report-749ec7.html#EndPath

PR validation:

runTheMatrix.py -l 136.793 -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

The code-checks are being triggered in jenkins.

@thomreis
Copy link
Contributor Author

thomreis commented May 7, 2020

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29766/15212

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented May 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6163/console Started: 2020/05/07 19:24

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

+1
Tested at: 510f077
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-819d35/6163/summary.html
CMSSW: CMSSW_11_1_X_2020-05-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-819d35/6163/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697175
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented May 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants