Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt tau validation for miniAOD-only workflows #29788

Merged
merged 3 commits into from May 10, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 9, 2020

this PR was initially triggered by observation of numerous printouts in re-miniAOD workflows like

 Reference collection not found while running TauValidationMiniAOD.cc

This PR replaces cerr (not allowed for production/centrally running code) with a LogWarning.
It looks like the fix to the underlying issue is simple, to add the produceDenoms to the prevalidationMiniAOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29788/15251

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/StandardSequences
Validation/RecoTau

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 9, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6196/console Started: 2020/05/09 07:53

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

+1
Tested at: 1013ffe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24c159/6196/summary.html
CMSSW: CMSSW_11_1_X_2020-05-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24c159/6196/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 41
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697167
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

+operations

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit bf0fd79 into cms-sw:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants