Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated interpolation tables #2980

Merged
merged 1 commit into from Apr 1, 2014

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Mar 23, 2014

A few updates to the interpolation tables, some cleanup, explicit constructors where needed, etc

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 for CMSSW_7_1_X.

updated interpolation tables

It involves the following packages:

JetMETCorrections/InterpolationTables

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@igv4321 igv4321 closed this Mar 23, 2014
@igv4321 igv4321 reopened this Mar 23, 2014
@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Mar 31, 2014

@igv4321 : Have these changes documented/presented somewhere? Where should effedcts show up?

@igv4321
Copy link
Contributor Author

igv4321 commented Mar 31, 2014

The changes are trivial -- mostly maintenance, so there is no detailed documentation. They affect my packages related to FFTJet jet corrections, mainly JetMETCorrections/FFTJetObjects and JetMETCorrections/FFTJetModules. As far as I can see, everything works just fine.

@vadler
Copy link

vadler commented Mar 31, 2014

I see. So, you expect output to be the same as before, and it indeed is?

@igv4321
Copy link
Contributor Author

igv4321 commented Mar 31, 2014

Yes, the code works the same as before. Interpolation tables do not generate output directly -- they are just used to store lookup tables of correction factors.

@vadler
Copy link

vadler commented Apr 1, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 1, 2014
AT -- Updated JetMETCorrections/InterpolationTables
@ktf ktf merged commit 79419ed into cms-sw:CMSSW_7_1_X Apr 1, 2014
@igv4321 igv4321 deleted the InterpolationTablesUpdate branch May 8, 2014 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants