DQM: Use process.maxLuminosityBlocks in the unit test #29801
Conversation
Much better than the previous 'solution'.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29801/15289
|
|
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: DQMServices/Demo @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Should be all fine. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Comparison job queued. |
| @@ -55,6 +56,9 @@ | |||
| processingMode = cms.untracked.string(args.processingMode)) | |||
|
|
|||
| process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(args.nEvents) ) | |||
| if args.nLumisections > 0: | |||
| process.maxLuminosityBlocks = cms.untracked.PSet( input = cms.untracked.int32(args.nLumisections) ) | |||
There was a problem hiding this comment.
FYI, you can now just do
process.maxLuminosityBlocks.input = args.nLumisections
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
As pointed out by @Dr15Jones in #29794 , this actually exists.
Much better than the previous 'solution'.
This should fix #29794 .
PR validation:
Unit tests pass. No other impact.