Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payload Inspector] Update derived classes to use fill() method for Histrogram1D after PR #29622 #29817

Merged
merged 1 commit into from May 13, 2020
Merged

[Payload Inspector] Update derived classes to use fill() method for Histrogram1D after PR #29622 #29817

merged 1 commit into from May 13, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 12, 2020

PR description:

Integration of PR #29622 introduced new warnings in CLANG IBs. This has been discussed in PR #29789.
It turns out, as highlighted in comments at #29789 (comment) that the method

virtual bool fill(const std::vector<std::tuple<cond::Time_t, cond::Hash>>& iovs) { ... }

has totally disappeared from cond::payloadInspector::Histogram*.
So the proper fix consists in migrating all the derived classes to use instead

cmssw/CondCore/Utilities/interface/PayloadInspector.h

Line 724 in 2963492

bool fill() override {

as at the moment all of these plots are not functional.

PR validation:

Compilation and unit tests run in standard IB. Compilation has been checked in CMSSW_11_1_CLANG_X_2020-05-10-2300 and errors reported at #29789 (comment) are not observed anymore.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 12, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented May 12, 2020

@smuzaffar I compiled my changes in CMSSW_11_1_CLANG_X_2020-05-10-230 as you have suggested at #29789 (comment).
I don't see anymore errors related to the ones reported in #29789, but I see a lot of:

/cvmfs/cms-ib.cern.ch/nweek-02628/slc7_amd64_gcc820/external/boost/1.72.0-bcolbf/include/boost/archive/basic_text_oprimitive.hpp:169:13: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
            const unsigned int digits = std::numeric_limits<T>::max_digits10;
            ^
/cvmfs/cms-ib.cern.ch/nweek-02628/slc7_amd64_gcc820/external/boost/1.72.0-bcolbf/include/boost/archive/basic_text_oprimitive.hpp:157:9: note: previous statement is here
        if(os.fail())

can you cross-check if that's normal?

@mmusich mmusich mentioned this pull request May 12, 2020
Closed
@mmusich mmusich changed the title [Payload Inspector] Upade fill() method for Histrogram1D after PR #29622 [Payload Inspector] Update derived classes to use fill() method for Histrogram1D after PR #29622 May 12, 2020
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29817/15327

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich mmusich force-pushed the fixFillMethodPayloadInspector branch from 4cc1335 to a6d0de9 Compare May 12, 2020 20:07
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29817/15328

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/AlignmentPlugins
CondCore/EcalPlugins
CondCore/RunInfoPlugins
CondCore/SiPixelPlugins
CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @mmusich, @dkotlins, @argiro, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6268/console Started: 2020/05/13 06:50

@smuzaffar
Copy link
Contributor 

boost/1.72.0-bcolbf/include/boost/archive/basic_text_oprimitive.hpp:169:13: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
            const unsigned int digits = std::numeric_limits<T>::max_digits10;

@mmusich, this are coming from boost. We can patch boost to avoid it but for now please ignore this.

@cmsbuild
Copy link
Contributor

+1
Tested at: a6d0de9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e438/6268/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7e438/6268/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697165
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 13, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a8d211a into cms-sw:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmusich @cmsbuild @smuzaffar @ggovi @silviodonato